Revert "Add clipBehavior to widgets with clipRect"#58344
Merged
Conversation
This reverts commit cd593da.
fluttergithubbot
added
f: material design
9 tasks
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
LGTM /cc @liyuqian FYI |
Contributor
|
This change also causes some breakages in the Fuchsia roll. @liyuqian is it possible to structure this as a soft-transition? cc: @chaselatta |
Contributor
|
It should be possible to have a soft-transition. The old PR was supposed to be non-breaking but clearly I missed something. Can you please attach the failed log here so I can make sure that my next try won't fail on the same test? |
Contributor
Author
Contributor
|
This is the failure log on the Fuchsia side: http://shortn/_Gy8PvjWzQG |
Contributor
|
The failure on our end came from |
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jun 17, 2020
)" (flutter#58344)" This reverts commit 1d395c5.
liyuqian
added a commit
that referenced
this pull request
Jun 17, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…r#55977" (flutter#59364) * Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)" This reverts commit 1d395c5. * Add missed Overflow
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…r#55977" (flutter#59364) * Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)" This reverts commit 1d395c5. * Add missed Overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #55977
Non trivial breakages in g3.