[WIP] Migrate Framework to use multi-window API#58696
Closed
gspencergoog wants to merge 3 commits intoflutter:masterfrom
Closed
[WIP] Migrate Framework to use multi-window API#58696gspencergoog wants to merge 3 commits intoflutter:masterfrom
gspencergoog wants to merge 3 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
a: accessibility
gspencergoog
changed the title
5 tasks
gspencergoog
force-pushed
the
multi_window_framework
branch
4 times, most recently
from
02384c6 to
4bff48a
Compare
gspencergoog
force-pushed
the
multi_window_framework
branch
from
4bff48a to
cd47031
Compare
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
Contributor
Author
|
Closing this for now, since it'll probably take a different form in the final version. Still working on this, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a work-in-progress PR for trying out the multi-window API on the framework repo. The goal here is to convert from the
windowsingleton to an API that has the concept of multiple windows. I'm not attempting to actually enable creating multiple windows here, just migrate to an API that has a concept of multiple windows/screens.I haven't yet updated any docs yet. I wrote some, and copy/pasted a lot all over without making sure they're consistent.
The API design doc for this is here.
The associated engine change is flutter/engine#18368.
Build is expected to fail, since it needs the corresponding engine change to succeed.
Related Issues
Tests
Breaking Change