Pesto logo now smoothly animates between image and image+text states.#5890
Pesto logo now smoothly animates between image and image+text states.#5890mpcomplete merged 1 commit intoflutter:masterfrom mpcomplete:logo
Conversation
There was a problem hiding this comment.
1.5*extraPadding -> 1.5 * extraPadding
There was a problem hiding this comment.
This is great. Much easier to read!
There was a problem hiding this comment.
We've been putting spaces in expressions like this, 1.5 * extraPadding
There was a problem hiding this comment.
You'll want a dispose override that _textController.dispose()
There was a problem hiding this comment.
You could Positioned.fromRect() here, with a Rect constant parameter.
There was a problem hiding this comment.
This is slick and I'm looking forward to seeing it.
I think it would be a little cleaner to create a Rect animation, like new RectTween(...).animate(_textController) and use it with an AnimatedBuilder below. And maybe call _textController just _controller.
There was a problem hiding this comment.
If you could use new Positioned.fromRect(rect: _imageRectAnimation.value) here
|
Ready for another look. |
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Just needs one small fix. LGTM
There was a problem hiding this comment.
The super.dispose() call should be last
72a38a6 Build Android engine in presubmit using Cirrus and GCE (flutter#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (flutter#5891) 723b278 Update license script README (flutter#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 89602cc [scenic] Expose compositor context from rasterizer. (flutter#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
72a38a6 Build Android engine in presubmit using Cirrus and GCE (#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (#5891) 723b278 Update license script README (#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886) 89602cc [scenic] Expose compositor context from rasterizer. (#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)
3 participants
Fixes #5684