Build iOS apps using Swift Packages#59009
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Jun 8, 2020
Merged
Conversation
jmagman
added
platform-ios
fluttergithubbot
added
d: examples
Member
Author
|
The difference between this and #58522 is cb5b9e2
#58522 |
christopherfujino
approved these changes
Jun 8, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, with one nit question
|
|
||
| @override | ||
| String migrateFileContents(String fileContents) { | ||
| const String podLocation = ''' |
Contributor
There was a problem hiding this comment.
nit. is this guaranteed to match, even with the surrounding whitespace?
Member
Author
There was a problem hiding this comment.
We generated this as part of the template with https://github.com/flutter/flutter/pull/4893/files#diff-fddbdff9cdb9e32ee9b9a95f74f30788R5-R8. Xcode and CocoaPods won't add it (at least how we have the project set up now).
jmagman
added a commit
that referenced
this pull request
Jun 8, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
10 tasks
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another attempt at #58522.
Swift packages cannot be added to a newly created Flutter iOS app due to the Xcode project settings (not workspace) being set to the "legacy" build location. Update to the "default" Xcode build location.
Update templates, add tool migrator, let tool upgrade all examples and integration tests.
Related Issues
Fixes #57083
Related to #49654
Tests
Migrator tests
Added the basic Apple example Swift package to an existing integration test. The adds a networked dependency to integration test, but hopefully Apple never removes this (and if they do, we can replace with another one).
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change