Support .flutter-plugins-dependencies#59209
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Jun 11, 2020
Merged
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jmagman
commented
Jun 10, 2020
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| require 'json' |
Member
Author
There was a problem hiding this comment.
Ruby std lib module available since Ruby 0.4, CocoaPods depends on it, safe to use here.
christopherfujino
approved these changes
Jun 11, 2020
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, with a nit about linking in comment to flutter.dev/go/plugins-list-migration
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
13 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parse
.flutter-plugins-dependenciesinstead of the old.flutter-pluginsto only embed theios-enabled plugins via CocoaPods..flutter-pluginswas a flat list of all plugins and their pub cache path, regardless of supported platform:.flutter-plugins-dependenciesis json:See https://docs.google.com/document/d/1W_IpXetVIgjHipKnu-zPHnDApdiwXR0RfugY6Sm8NAg/edit
Related Issues
Fixes #39659
Tests
Updated integration test to test a plugin that doesn't support iOS.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change