Skip to content

Revert "Roll Engine from 965fbbed1776 to 801559ac4ed3 (50 revisions)"#59490

Merged
dnfield merged 1 commit intomasterfrom
revert-59384-flutter-engine-flutter-autoroll
Jun 15, 2020
Merged

Revert "Roll Engine from 965fbbed1776 to 801559ac4ed3 (50 revisions)"#59490
dnfield merged 1 commit intomasterfrom
revert-59384-flutter-engine-flutter-autoroll

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 15, 2020

Reverts #59384

This made the devicelab very red.

TBR @iskakaushik

@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Jun 15, 2020
@dnfield dnfield merged commit 3dad0a2 into master Jun 15, 2020
@dnfield dnfield deleted the revert-59384-flutter-engine-flutter-autoroll branch June 15, 2020 19:00
@dnfield
Copy link
Contributor Author

dnfield commented Jun 15, 2020

/cc @gw280 who I think is sherrif right now.

@gw280
Copy link
Contributor

gw280 commented Jun 15, 2020

Reference: https://flutter-dashboard.appspot.com/#/build

Not looking good. Investigating

@dnfield
Copy link
Contributor Author

dnfield commented Jun 15, 2020

Most likely culprit seems to be Dart roll, since it seems like all mac specific VM Service connection failures.

@iskakaushik
Copy link
Contributor

LGTM

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants