[flutter_tools] update libimobiledevice#59512
Merged
christopherfujino merged 3 commits intoflutter:masterfrom Jun 29, 2020
Merged
[flutter_tools] update libimobiledevice#59512christopherfujino merged 3 commits intoflutter:masterfrom
christopherfujino merged 3 commits intoflutter:masterfrom
Conversation
Member
|
I locally smoke tested upgraded libimobiledevice, libusbmuxd, libplist (not openssl, etc) and it seemed to all work. |
goderbauer
added
the
tool
christopherfujino
force-pushed
the
update-libimobiledevice
branch
from
b490ce1 to
1cb3b26
Compare
jmagman
force-pushed
the
update-libimobiledevice
branch
from
1fb8e48 to
4e914da
Compare
Contributor
Author
|
I should land #60391 before this one. |
10 tasks
Contributor
Author
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
@jmagman your changes LGTM. Can I get your approval too?
christopherfujino
added a commit
that referenced
this pull request
Jun 29, 2020
This reverts commit 32000db.
christopherfujino
added a commit
that referenced
this pull request
Jun 29, 2020
Contributor
Author
|
Reverted because of #60559 |
christopherfujino
added a commit
that referenced
this pull request
Jun 30, 2020
christopherfujino
added a commit
that referenced
this pull request
Jun 30, 2020
10 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…tter#60551) This reverts commit 32000db.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…" (flutter#60551)" (flutter#60569) This reverts commit 09cca73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Fixes #59506
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.