[web] Support custom url strategies#59797
Merged
fluttergithubbot merged 10 commits intoflutter:masterfrom Oct 9, 2020
Merged
Conversation
mdebbar
added
f: routes
fluttergithubbot
added
c: contributor-productivity
mdebbar
force-pushed
the
custom_location_strategy
branch
from
b7ec028 to
2c71b7b
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
|
This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it. |
mdebbar
force-pushed
the
custom_location_strategy
branch
from
2c71b7b to
86a8f9c
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Closed
10 tasks
mdebbar
force-pushed
the
custom_location_strategy
branch
2 times, most recently
from
f52b10c to
1c19569
Compare
Contributor
Author
|
@yjbanov @hterkelsen @chunhtai this PR is ready for review. |
yjbanov
reviewed
Sep 25, 2020
packages/flutter_web_plugins/lib/src/history/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/history/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/history/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/history/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/test/history/url_strategy_test.dart
Outdated
Show resolved
Hide resolved
mdebbar
force-pushed
the
custom_location_strategy
branch
from
4c33113 to
6cb8a79
Compare
Contributor
Author
|
@yjbanov this is ready for another pass. Main things I did:
|
mdebbar
force-pushed
the
custom_location_strategy
branch
from
6cb8a79 to
46f2c3f
Compare
yjbanov
approved these changes
Oct 8, 2020
packages/flutter_web_plugins/lib/src/history/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/navigation/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/navigation/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
packages/flutter_web_plugins/lib/src/navigation/js_url_strategy.dart
Outdated
Show resolved
Hide resolved
mdebbar
force-pushed
the
custom_location_strategy
branch
from
348a6b4 to
a82ab25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose a Dart API allowing apps to customize the url strategy.
Companion PR: flutter/engine#19134
Fixes #33245