[flutter_tools] separate target platform, host platform, and architecture#60119
[flutter_tools] separate target platform, host platform, and architecture#60119jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
| android_x86, | ||
| } | ||
|
|
||
| enum WindowsArch { |
There was a problem hiding this comment.
Should these not be target platforms? for reference TODO on 431.
There was a problem hiding this comment.
Actually going the exact opposite direction, target platforms are already super overloaded. Rather than say "hey we're building for ios_armA, ios_armB" we say "hey we're building for ios, with architectures armA, armB"
There was a problem hiding this comment.
Ok, that makes sense. I'm thinking that, in terms of the cache refactor, I should re-write these as classes then, so that we can model the hierarchical relationship.
There was a problem hiding this comment.
I think for caching we can flatten them back out to strings. But we should update the cache to distinguish between HostPlatform and TargetPlatform if possible
|
Google testing failed... |
…utre (flutter#60119) separate target platform, host platform, and architecture
…architecutre (flutter#60119)" (flutter#60147) This reverts commit 30d97d8.
6 participants
Description
A rename, just to start getting in the right mindset