Turn on iOS wireless debugging, connect to remote observatory by jmagman · Pull Request #60408 · flutter/flutter

jmagman · 2020-06-27T02:37:29Z

Description

Use new --network libimobiledevice flags.

flutter run, flutter attach --host-vmservice-port, flutter install, flutter screenshot work.

Related issues

#15072

Steps to test

Attach a phone to your Mac. This works best when both are on the same Wi-Fi network (unrelated to Flutter).
Make sure the device has a passcode set.
Open Xcode > Window > Devices and Simulators > Choose your phone, then check Connect via Network

(If you don't get that little network icon next to the device name it probably didn't work, regardless of checkbox state.)
Unplug your device from USB.

Tests

mac_test.dart
xcode_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.

jmagman · 2020-06-27T02:38:21Z

\cc @zanderso @DanTup @dnfield @jonahwilliams Any insight on this one?

Edit: @anirudhb figured it out and I updated with the suggested change. Please ignore. 🙂

jmagman · 2020-06-27T02:59:26Z

@anirudhb Were you ever actually able to get #58185 working and attaching to the observatory? (Thank you again for that contribution! Fortunately the newest version of iproxy handles the IP lookup for us, so we don't need to do any stdout parsing). I also got "Connection refused" issues when I ran your PR, though it may have been because the IP wasn't parsed correctly on my machine, and even when the host and target were on the same network I still get the Non-authoritative output (maybe a hint?).

If you did have it working on your PR, would you mind testing this PR with the same setup? Did you have to set up anything special to get it working?

anirudhb · 2020-06-27T03:01:19Z

I didn’t try anything yet but glancing at the observatory logs it seems you forgot to pass —observatory-host 0.0.0.0 to the app arguments.

jmagman · 2020-06-27T03:23:29Z

I didn’t try anything yet but glancing at the observatory logs it seems you forgot to pass —observatory-host 0.0.0.0 to the app arguments.

@anirudhb Good eye, that was totally it. Thank you so much!

anirudhb · 2020-07-07T21:08:06Z

Regarding the performance of this, it seems that install always copies all files to the device (including Flutter.framework) which is unreasonably large and slow. Have you looked into making Flutter's build work with app deltas? (This doesn't work currently since the build script seems to be touching Flutter.framework, forcing it to be copied.)

jmagman · 2020-07-08T21:25:28Z

Regarding the performance of this, it seems that install always copies all files to the device (including Flutter.framework) which is unreasonably large and slow. Have you looked into making Flutter's build work with app deltas? (This doesn't work currently since the build script seems to be touching Flutter.framework, forcing it to be copied.)

The version of ios-deploy we're embedding doesn't support app-deltas yet (we're back on 1.10.0-beta.3), but we'll need to upgrade soon to support Xcode 12 (see #60072 (comment)). We can explore that separately since it'll help non-wireless install times as well.

anirudhb · 2020-07-11T00:21:51Z

fwiw I did try the new ios-deploy with app deltas, but it seems that Flutter builds the app in such a way that app deltas copies the entire app again (including Flutter.framework, which shouldn't've even changed.)

The app install time is extremely noticeable over wireless, whereas over USB it's not as significant.

jmagman · 2020-07-11T02:14:20Z

fwiw I did try the new ios-deploy with app deltas, but it seems that Flutter builds the app in such a way that app deltas copies the entire app again (including Flutter.framework, which shouldn't've even changed.)

The app install time is extremely noticeable over wireless, whereas over USB it's not as significant.

That doesn't surprise me, we scorch earth that framework on every build because people kept submitting the debug version to the App Store, which gets at best gets a rejection and at worst causes a 100% crash on launch. I've hopefully plugged enough holes with that logic that maybe we can be less aggressive, but we'll have to investigate further. I'm comfortable turning this feature on even if it's painfully slow, and we can improve later.

anirudhb · 2020-07-11T20:27:06Z

I did some investigation on this, and the gist of it is that Xcode only uses modification time to determine whether to copy a file or not. Some things in the build that change modification time include code signing and framework thinning. Cocoapods additionally does this as well (this could be an upstream issue). After modifying the scripts to preserve modification time across codesign/thin, ~~Xcode was successfully able to use app deltas!~~ edit: Crazy run errors including a white screen on launch.

A proper implementation of this would probably involve hash comparisons, since Xcode doesn't do this for some reason when computing app deltas.

jmagman · 2020-08-29T00:17:10Z

I removed the longer timeouts in favor of a new flag #64834. With both this change and that one, it's working on iOS 13 and Xcode 11. Unfortunately I'm hitting debug attach issues on Xcode 12/iOS 14.

fluttergithubbot · 2020-09-01T18:28:26Z

This pull request is not suitable for automatic merging in its current state.

Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

xster · 2020-09-02T22:50:13Z

packages/flutter_tools/lib/src/ios/devices.dart

      '--disable-service-auth-codes',
      '--observatory-port=$assumedObservatoryPort',
+      if (interfaceType == IOSDeviceInterface.network)
+        '--observatory-host=${ipv6 ? '::/0' : '0.0.0.0'}',


add comment for reader

Also see flutter/engine#9485.

xster · 2020-09-02T22:51:00Z

packages/flutter_tools/lib/src/ios/devices.dart

    @required String id,
    @required IProxy iproxy,
    @required OperatingSystemUtils operatingSystemUtils,
+    @required IOSDeviceInterface interfaceType,


ultra nit / feel free to ignore: IOSDeviceConnectionInterface? Just interface is a bit vague.

xster

LGTM

christopherfujino

LGTM

jmagman · 2020-09-03T02:45:32Z

Not working on iOS 14 again...

christopherfujino · 2020-09-03T18:02:23Z

I guess re-requesting a review doesn't remove an approval, as far as GitHub is concerned?

christopherfujino

Just trying to clear out my previous approval...in case the mergebot goes crazy again and tries to merge it.

flutter-dashboard · 2020-09-23T18:20:08Z

This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it.

fluttergithubbot · 2020-10-09T02:12:14Z

This pull request is not suitable for automatic merging in its current state.

This pull request has changes requested by @christopherfujino. Please resolve those before re-applying the label.
The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

christopherfujino · 2020-10-09T16:12:19Z

Just trying to clear out my previous approval...in case the mergebot goes crazy again and tries to merge it.

I look like a genius now :)

jmagman · 2021-04-22T20:44:49Z

This is well out of date, closing.

jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 27, 2020

jmagman self-assigned this Jun 27, 2020

fluttergithubbot added the work in progress; do not review label Jun 27, 2020

googlebot added the cla: yes label Jun 27, 2020

jmagman force-pushed the wireless-network-flag branch from 4c8e1fe to 6dc3f9b Compare June 30, 2020 20:32

jmagman force-pushed the wireless-network-flag branch from 6dc3f9b to 5e97165 Compare July 8, 2020 21:55

jmagman force-pushed the wireless-network-flag branch from 5e97165 to 7536906 Compare August 28, 2020 23:40

fluttergithubbot removed the work in progress; do not review label Sep 1, 2020

jmagman marked this pull request as ready for review September 2, 2020 19:12

jmagman requested review from christopherfujino and xster September 2, 2020 19:12

jmagman added 2 commits September 2, 2020 15:39

Enable wireless debugging on iOS

e00cde4

Set --observatory-host

3e43366

jmagman force-pushed the wireless-network-flag branch from 7536906 to 3e43366 Compare September 2, 2020 22:40

xster reviewed Sep 2, 2020

View reviewed changes

christopherfujino approved these changes Sep 2, 2020

View reviewed changes

Review edits

994559a

jmagman added the work in progress; do not review label Sep 3, 2020

christopherfujino self-requested a review September 3, 2020 17:51

christopherfujino suggested changes Sep 3, 2020

View reviewed changes

jmagman marked this pull request as draft September 23, 2020 18:48

jmagman mentioned this pull request Sep 23, 2020

Stale Gold comment in GitHub PR is confusing #66478

Closed

jmagman mentioned this pull request Oct 7, 2020

Use app deltas for faster and smaller incremental iOS app installs #67580

Closed

fluttergithubbot removed the work in progress; do not review label Oct 9, 2020

jmagman closed this Apr 22, 2021

This was referenced Aug 13, 2021

flutter run should support wireless debugging of iOS devices #15072

Closed

Rename IOSDeviceInterface to IOSDeviceConnectionInterface #88144

Merged

Conversation

jmagman commented Jun 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Steps to test

Tests

Checklist

Breaking Change

Uh oh!

jmagman commented Jun 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Jun 27, 2020

Uh oh!

anirudhb commented Jun 27, 2020

Uh oh!

jmagman commented Jun 27, 2020

Uh oh!

anirudhb commented Jul 7, 2020

Uh oh!

jmagman commented Jul 8, 2020

Uh oh!

anirudhb commented Jul 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Jul 11, 2020

Uh oh!

anirudhb commented Jul 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Aug 29, 2020

Uh oh!

fluttergithubbot commented Sep 1, 2020

Uh oh!

xster Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

xster Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

xster left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Sep 3, 2020

Uh oh!

christopherfujino commented Sep 3, 2020

Uh oh!

christopherfujino left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Sep 23, 2020

Uh oh!

fluttergithubbot commented Oct 9, 2020

Uh oh!

christopherfujino commented Oct 9, 2020

Uh oh!

jmagman commented Apr 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmagman commented Jun 27, 2020 •

edited

Loading

jmagman commented Jun 27, 2020 •

edited

Loading

anirudhb commented Jul 11, 2020 •

edited

Loading

anirudhb commented Jul 11, 2020 •

edited

Loading

christopherfujino left a comment •

edited

Loading