Skip to content

New license page with fix for zero licenses.#60552

Merged
gspencergoog merged 3 commits intoflutter:masterfrom
gspencergoog:reland_licenses_with_fix
Jun 30, 2020
Merged

New license page with fix for zero licenses.#60552
gspencergoog merged 3 commits intoflutter:masterfrom
gspencergoog:reland_licenses_with_fix

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Jun 29, 2020

Description

This amends #57588 by adding code that also handles the zero license case, and adds translation strings for that.

Tests

  • Modified tests to take into account zero licenses.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.

… that have zero licenses."

This reverts commit f1b9fdf.
Generate missing arb entries

Add README

Add some more missing entries

Fix failure when there are no licenses
@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 29, 2020
@gspencergoog gspencergoog changed the title Reland: New license page with fix for zero licenses. New license page with fix for zero licenses. Jun 30, 2020
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog merged commit ca71355 into flutter:master Jun 30, 2020
@gspencergoog gspencergoog deleted the reland_licenses_with_fix branch June 30, 2020 16:15
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
This amends flutter#57588 by adding code that also handles the zero license case, and adds translation strings for that.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants