Skip to content

Remove superfluous GestureDetector.#60730

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
TonicArtos:license_page
Jul 8, 2020
Merged

Remove superfluous GestureDetector.#60730
fluttergithubbot merged 1 commit intoflutter:masterfrom
TonicArtos:license_page

Conversation

@TonicArtos
Copy link
Contributor

Description

Remove superfluous GestureDetector in changes from #60552.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
    • Runs with flutter update-packages --force-upgrade.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 2, 2020
@TonicArtos TonicArtos mentioned this pull request Jul 2, 2020
12 tasks
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TonicArtos
Copy link
Contributor Author

I'll figure out what is going on with the docs-linux test.

@TonicArtos
Copy link
Contributor Author

TonicArtos commented Jul 6, 2020

Okay. I've re-based onto de205ec as it is the most recent green master commit. Should be good.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-2-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TonicArtos
Copy link
Contributor Author

Okay, looks like it is good to go this time.

@fluttergithubbot fluttergithubbot merged commit a167610 into flutter:master Jul 8, 2020
@TonicArtos TonicArtos deleted the license_page branch July 8, 2020 02:10
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants