Add comment explain dispatchEvent override#60734
Merged
CareF merged 1 commit intoflutter:masterfrom Jul 8, 2020
CareF:add_comments_to_binding
Merged
Add comment explain dispatchEvent override#60734CareF merged 1 commit intoflutter:masterfrom CareF:add_comments_to_binding
CareF merged 1 commit intoflutter:masterfrom
CareF:add_comments_to_binding
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
a: tests
liyuqian
reviewed
Jul 7, 2020
Contributor
There was a problem hiding this comment.
Would {TestBindingEventSource source,} instead of {TestBindingEventSource source = TestBindingEventSource.device,} have the same effect here and reduce the confusion?
Contributor
Author
There was a problem hiding this comment.
I'm guessing for an enum, leaving it null is not preferred.
9 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comments explaining the special override behavior for
TestWidgetSFlutterBinding .dispatchEventRelated Issues
N/A
Tests
Add comments, don't need.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.