A solution to record gestures and using the record for tests#60741
Closed
CareF wants to merge 15 commits intoflutter:masterfrom
CareF:record_gesture
Closed
A solution to record gestures and using the record for tests#60741CareF wants to merge 15 commits intoflutter:masterfrom CareF:record_gesture
CareF wants to merge 15 commits intoflutter:masterfrom
CareF:record_gesture
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
CareF
commented
Jul 2, 2020
Contributor
Author
There was a problem hiding this comment.
This assert doesn't take into consideration multiple input events at the same time. This often happen for PointerAddedEvent and PointerDownEvent
Contributor
Author
|
This PR is serving as an overview of motivation for multiple smaller PRs. |
9 tasks
This was referenced Jul 6, 2020
Closed
Contributor
Author
|
Close for now because it may be able to be implemented outside the framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the test purposes sometimes we want the input to be as close as possible to real world input, e.g. for making a test case for #19222 . To achieve this we want a way to record the input events and use the record to make test cases.
Related Issues
Closes #60650, closes #60649
Tests
I added the following tests:
TBD
A use case can be seen in https://github.com/CareF/scroll_test :
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.