Merged
Conversation
Contributor
|
Isn't the plan to go with a "watch" command that does continuous analysis and testing in the background? |
Contributor
Author
|
@Hixie |
Contributor
|
LGTM but @devoncarew would probably be a better reviewer. |
devoncarew
reviewed
Oct 4, 2016
| }); | ||
|
|
||
| group('watch', () { | ||
| group('analyze --watch', () { |
Contributor
There was a problem hiding this comment.
No preference, but you could remove this file completely, and move the analyze --watch group into analyze_test.dart.
Contributor
Author
There was a problem hiding this comment.
I'd like to keep them separate because the implementations are separate but I just realized I should rename this to analyze_watch_test.dart
Contributor
|
lgtm |
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
Oct 4, 2016
yjbanov
added a commit
that referenced
this pull request
Oct 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the analyze once and continuous analysis implementations separated, but merge the
flutter watchback into analyze asflutter analyze --watch.@Hixie