prevents sliver app bar from changing semantics tree when it is not n…#61012
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jul 9, 2020
Merged
prevents sliver app bar from changing semantics tree when it is not n…#61012fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
Member
What is the root cause there? Can we fix it in the bridge? Also, did you double check that this does not break anything with regards to implicit a11y scrolling on Android? |
Member
|
Looks like some test is failing on cirrus as well. |
Contributor
Author
|
The bridge is working correctly. The issue only happened when ios a11y focus on the sliver list content and then framework sends semantics updates to the a11y bridge that change the shape of the tree due to the |
Contributor
Author
|
the cirrus is happy after rerun, the previous failure is a flake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ecesaary
Description
When ios swipe up to focus a collapsed sliver app bar, the semantics tree suddenly change its shape and ios accessibility api can not handle it. The root cause is in the native ios side. This pr is a workaround to prevent this situation by not changing the shape of semantics tree when it is not necessary.
Related Issues
Fixes #60331
Tests
I added the following tests:
existing test coverage
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.