Mouse events report correct local positions#61190
Merged
fluttergithubbot merged 8 commits intoflutter:masterfrom Jul 13, 2020
Merged
Mouse events report correct local positions#61190fluttergithubbot merged 8 commits intoflutter:masterfrom
fluttergithubbot merged 8 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
framework
gspencergoog
approved these changes
Jul 9, 2020
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Looks pretty good! I'm excited that this will finally report the right thing.
| import 'package:flutter/gestures.dart'; | ||
| import 'package:flutter/scheduler.dart'; | ||
| import 'package:flutter/services.dart'; | ||
| import 'package:vector_math/vector_math_64.dart'; |
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the mouse events (enter, hover exit) so that the event objects contain correct
localPositions.Related Issues
Tests
No tests are added. Existing tests are added so that they also test local positions.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.