Remove v1 Android create templates#61203
Merged
xster merged 2 commits intoflutter:masterfrom Jul 11, 2020
Merged
Conversation
fluttergithubbot
added
c: contributor-productivity
|
nice! I was gonna ping you about when to delete the old embedding from |
blasten
approved these changes
Jul 10, 2020
Member
Author
|
well that's probably gonna be the very last step |
Member
Author
|
well, it's a chicken and egg issue. I need to know the time when this is merged so I'll merge this first then merge the breaking change announce website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter.dev/go/android-migration-summary
Remove the creation template stubs for v1 embedding apps and plugins targeting v1 embeddings.
v1 usage ratio is now 26% for apps.
This PR removes the feature flag for app and plugin creations. It does not affect reporting which is determined independently. It does not affect current v1 embedding apps or v1 targeting plugins. Current v1 apps using current v1 targeting plugins will continue to generate the correct registrations. The generation is also determined independently.
The soft breaking change from this PR is that if a plugin developer creates a new plugin today and publishes it, v1 embedding app developers will see a prompt to update their app's embedding. Though the message and the trigger has been there all year, this increases the likelihood of that message being seen.
Breaking change website PR: flutter/website#4328