Parse .flutter-plugins-dependencies for add-to-app iOS modules#61269
Parse .flutter-plugins-dependencies for add-to-app iOS modules#61269fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
jmagman
added
platform-ios
fluttergithubbot
added
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
what is defined_in_file? is this a pod magic function?
There was a problem hiding this comment.
nvm, I grepped the codebase and found y our other comments about it
There was a problem hiding this comment.
I copied the comments to this file.
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
add a code comment or reference issue for when this can happen?
There was a problem hiding this comment.
I don't think it can ever happen AFAIK, I think I just wanted a way to surface Something Bad Happened and stopping instead of copying from a nonexistent directory in https://github.com/flutter/flutter/pull/59044/files#diff-76053fa099530bf75a339336cccbc2efR23.
jmagman
force-pushed
the
add-to-app-podhelper
branch
from
0d1fb59 to
067483a
Compare
6 participants
Description
Parse
.flutter-plugins-dependenciesin Flutter modules to not pull in plugins that don't support iOS. Pretty close to #59209 but for the module template.Related Issues
Fixes #59811
#59209
Tests
Updated module_test_ios to depend on
android_alarm_manager, then make sure there's noandroid_alarm_managerembedded in the host app.