[flutter_tools] turn down flutter generate#61475
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Jul 16, 2020
Merged
[flutter_tools] turn down flutter generate#61475jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams merged 2 commits intoflutter:masterfrom
Conversation
Contributor
|
The code change looks good to me. Can we delete this command in one commit, though? I'm thinking of both of internal implementations and external users using the command in their workflow. |
Contributor
Author
|
There should be no google3 implications as it is unused. I did land the deprecation earlier #58328 which should be in the next stable |
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
complete removal of all generate functionality Fixes flutter#61508
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
complete removal of all generate functionality Fixes flutter#61508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
complete removal of all generate functionality
Fixes #61508