Skip to content

Remove run_machine_concurrent_hot_reload device lab test#61573

Merged
DanTup merged 1 commit intoflutter:masterfrom
DanTup:remove-concurrent-hot-reload-device-lab-test
Jul 15, 2020
Merged

Remove run_machine_concurrent_hot_reload device lab test#61573
DanTup merged 1 commit intoflutter:masterfrom
DanTup:remove-concurrent-hot-reload-device-lab-test

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Jul 15, 2020

This was testing that concurrent reloads were rejected. This is now allowed (as of #55376 (which has non-device-lab integration + unit tests).

This was testing that concurrent reloads were rejected. This is now allowed (as of #55376 (which has non-devicelab integration + unit tests).
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 15, 2020
@DanTup DanTup requested a review from jonahwilliams July 15, 2020 20:37
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup
Copy link
Contributor Author

DanTup commented Jul 15, 2020

Landing on red to fix devicelab failure.

@DanTup DanTup merged commit 9c4a5ef into flutter:master Jul 15, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
This was testing that concurrent reloads were rejected. This is now allowed (as of flutter#55376 (which has non-devicelab integration + unit tests).
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
This was testing that concurrent reloads were rejected. This is now allowed (as of flutter#55376 (which has non-devicelab integration + unit tests).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants