Add tests for platform views' hover behavior #61667
Merged
goderbauer merged 11 commits intoflutter:masterfrom Jul 29, 2020
Merged
Add tests for platform views' hover behavior #61667goderbauer merged 11 commits intoflutter:masterfrom
goderbauer merged 11 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
framework
mdebbar
approved these changes
Jul 16, 2020
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
Piinks
added
a: mouse
Member
|
fly-by comment: looks like cirrus is unhappy. |
…into platform-view-hittest-behavior
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While #59883 has already (largely) fixed #58616, this PR adds tests for it. Also, this PR fixed an issue where changing the behavior didn't trigger re-hittest.
Related Issues
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.