iOS hasStrings and the clipboard notification#61774
iOS hasStrings and the clipboard notification#61774justinmc wants to merge 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
PR triage: Looks like the engine side was submitted. Is this ready? |
|
No, I need to add hasStrings to all the other platforms in addition to iOS. I have an Android PR at flutter/engine#20393 and will follow up with the others. I've added this to the description. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
Bad bot. :) |
|
This PR is hanging around for awhile while I finish all the engine dependencies, I'm probably confusing the bot. |
|
This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
PR triage update from @justinmc: "I need to do a PR for Windows and a PR for Fuchsia." |
|
Closing this for now until I have time to work on Windows and Fuchsia engine methods, at which point I'll reopen. |
Description
Uses the iOS hasStrings method that's being added in the engine in flutter/engine#19859 to avoid iOS's clipboard notification.
Related Issues
Closes #60145
Depends on flutter/engine#19859
Depends on flutter/engine#20393
Depends on flutter/engine#20531
Depends on flutter/engine#21388 and more to come for other platforms
Tests
I added the following tests:
TODO
Breaking Change
None