Add WidgetController.scrollUntilVisible#62097
Merged
fluttergithubbot merged 7 commits intoflutter:masterfrom Jul 28, 2020
CareF:scroll_until_visible
Merged
Add WidgetController.scrollUntilVisible#62097fluttergithubbot merged 7 commits intoflutter:masterfrom CareF:scroll_until_visible
fluttergithubbot merged 7 commits intoflutter:masterfrom
CareF:scroll_until_visible
Conversation
fluttergithubbot
added
a: tests
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
dnfield
reviewed
Jul 23, 2020
Contributor
Author
|
@dnfield PTAL |
Contributor
Author
|
I should have used |
Contributor
Author
|
I realize one problem with this design. In many widgets, |
9 tasks
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
9 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an equivalence for
FlutterDriver.scrollUntilVisible, to find the widgets long below a scrollable, that's not built yet.It's necessary for migrating tests like #62064
Related Issues
Fixes #61458
Tests
I added the following tests:
'scrollUntilVisible: scrolls to make unbuilt widget visible'group inpackages/flutter_test/test/controller_test.dartChecklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.