[flutter_tools]Set plugin template min flutter sdk version to 1.20#62605
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Aug 4, 2020
Merged
[flutter_tools]Set plugin template min flutter sdk version to 1.20#62605fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
cyanglaz
changed the title
jmagman
approved these changes
Jul 30, 2020
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
If this is what was agreed on, code LGTM!
jmagman
reviewed
Jul 30, 2020
| @@ -6,7 +6,7 @@ homepage: | |||
|
|
|||
| environment: | |||
| sdk: ">=2.7.0 <3.0.0" | |||
Member
There was a problem hiding this comment.
We could also change the sdk version, though it doesn't matter too much since it's shipped with Flutter.
Member
There was a problem hiding this comment.
If you want to do that, it would become >=2.9.0
Contributor
Author
There was a problem hiding this comment.
I don't see any risk of that but since we are cherry picking this, let's make it as simple as possible. We can always update the sdk version later. WDYT?
Contributor
Author
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting the min flutter sdk version to 1.20.0
After 1.20.0, newly created plugins won't contain no-op iOS folders. Which requires the sdk version to be 1.20.0 or above.
WARNING
Landing this PR before 1.20 release will have below impacts:
Related Issues
#60215
Tests
I added the following tests:
newly created plugin has min flutter sdk version as 1.20.0
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.