Add integration test for plugins without ios directories#62630
Merged
jmagman merged 2 commits intoflutter:masterfrom Aug 3, 2020
Merged
Add integration test for plugins without ios directories#62630jmagman merged 2 commits intoflutter:masterfrom
jmagman merged 2 commits intoflutter:masterfrom
Conversation
jmagman
added
a: tests
jmagman
force-pushed
the
plugin-ios-integration
branch
from
bb0f75a to
1c06f1b
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration test to create an Android-only plugin with no
iosdirectory, then add that dependency to another plugin. Make sure the other plugin can build for iOS, and doesn't embed the Android-only plugin.Related Issues
#61561
I locally verified this integration test passes on top of #62372
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See [Test Coverage].
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change