Skip to content

Address misc time picker design issues#62803

Merged
fluttergithubbot merged 6 commits intoflutter:masterfrom
rami-a:time-picker-misc-fixes
Aug 4, 2020
Merged

Address misc time picker design issues#62803
fluttergithubbot merged 6 commits intoflutter:masterfrom
rami-a:time-picker-misc-fixes

Conversation

@rami-a
Copy link
Contributor

@rami-a rami-a commented Aug 3, 2020 •
edited
Loading

Description

This change makes small tweaks to time picker to ensure it matches the design spec (to be published soon!)

  • Using bodyText1 on the dial numbers instead of subtitle1
  • Making sure dial numbers use color scheme values
  • Limit textfield entry to 2 characters
  • Ensure providing a custom inputDecorationTheme still allows the focused fill color behavior
  • Ensure that when locale is RTL, the hours/minutes do not get swapped

Related Issues

Fixes #62775

Tests

I added the following tests:

  • Updated existing tests

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 3, 2020
willlarche
willlarche reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@willlarche willlarche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/time_picker.dart
child: TextFormField(
expands: true,
maxLines: null,
inputFormatters: <TextInputFormatter>[
Copy link
Contributor

@willlarche willlarche Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 line?

Copy link
Contributor Author

@rami-a rami-a Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxLines has to be null for the expands logic to work, so we limit to 2 characters

packages/flutter/lib/src/material/time_picker.dart Outdated
),
onPressed: _handleEntryModeToggle,
icon: Icon(_entryMode == TimePickerEntryMode.dial ? Icons.keyboard : Icons.access_time),
icon: Icon(_entryMode == TimePickerEntryMode.dial ? Icons.keyboard_outlined : Icons.access_time),
Copy link
Contributor

@willlarche willlarche Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outlined for M2?

Copy link
Contributor Author

@rami-a rami-a Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that is expected

@rami-a rami-a requested a review from HansMuller August 3, 2020 20:09
HansMuller
HansMuller approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however these changes are likely to break golden image tests.

@rami-a
Copy link
Contributor Author

rami-a commented Aug 3, 2020

I've disabled my internal golden tests while I work through these changes internally and externally. So I think it will be ok to land this

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 3, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard flutter-dashboard bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Aug 4, 2020
@rami-a rami-a mentioned this pull request Aug 4, 2020
Closed
@rami-a rami-a requested a review from HansMuller August 4, 2020 14:09
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 4, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-3-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit f29f05e into flutter:master Aug 4, 2020
@rami-a rami-a mentioned this pull request Aug 7, 2020
Closed
@rami-a rami-a deleted the time-picker-misc-fixes branch August 10, 2020 14:39
@pcsosinski
Copy link

pcsosinski commented Aug 10, 2020

removing CP label in favor of #62775

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@rami-a @Pragya007
Address misc time picker design issues (flutter#62803)
ae15a7a
@rami-a rami-a mentioned this pull request Aug 12, 2020
Closed
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request Aug 12, 2020
@rami-a
Address misc time picker design issues (flutter#62803)
f2445c5
@rami-a rami-a mentioned this pull request Aug 12, 2020
Merged
13 tasks
pcsosinski pushed a commit that referenced this pull request Aug 13, 2020
@Piinks @jmagman
@rami-a @darrenaustin
1.20.2 Cherrypicks (#63591)
bbfbf17 
* Fix SliverList scrollOffsetCorrection 0 case (#62615)

* Case insensitive check flavor names against Xcode schemes (#61140)

* Address misc time picker design issues (#62803)

* Update to the latest localizations (#63026)

* Removed the inputFormatters from the text input fields used by the Date Pickers (#63461)

* Fix App.framework path in Podfile (#63412)

* Update engine hash to 1.20.2

Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Rami <[email protected]>
Co-authored-by: Shi-Hao Hong <[email protected]>
Co-authored-by: Darren Austin <[email protected]>
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@rami-a @mingwandroid
Address misc time picker design issues (flutter#62803)
78eeac2
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnsonmh johnsonmh johnsonmh approved these changes

+2 more reviewers

@willlarche willlarche willlarche left review comments

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TimePicker is not correct in RTL languages

7 participants

@rami-a @fluttergithubbot @pcsosinski @willlarche @HansMuller @johnsonmh @googlebot