[hotfix] flutter create -t plugin remove no-op iOS folder and set sdk min to 1.20.0#62939
[hotfix] flutter create -t plugin remove no-op iOS folder and set sdk min to 1.20.0#62939cyanglaz wants to merge 3 commits intoflutter:flutter-1.20-candidate.7from
Conversation
flutter-dashboard
bot
changed the base branch from
flutter-1.20-candidate.7
to
master
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
1 similar comment
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
added
engine
|
@pcsosinski @csells This is the hotfix PR. Edit: |
|
I think we should cherry-pick #62630 in as well, which adds more tests. So we can be more confident. @jmagman @pcsosinski WDYT? |
cyanglaz
force-pushed
the
1_21_remove_ios_folder
branch
from
f728d5b to
863efe8
Compare
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM with a nit about removing a TODO comment.
| @@ -1542,7 +1543,7 @@ void main() { | |||
|
|
|||
| // TODO(cyanglaz): no-op iOS folder should be removed after 1.20.0 release | |||
|
Experienced some issue with tags. Closing this in favor of #62990 |
2 participants
This is a cherry-pick of 004f90f and 2459f5c
Fixes #60215