[hotfix] flutter create -t plugin remove no-op iOS folder and set sdk min to 1.20.0#62990
Conversation
flutter-dashboard
bot
changed the base branch from
flutter-1.20-candidate.7
to
master
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
1 similar comment
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
added
engine
|
@christopherfujino I experienced some git tag issue with my previous rebased, so I closed the other PR(#62939) you just reviewed in favor of this one. Could you give another review? |
|
@pcsosinski The flutter version is not reported correctly so the tests are failing on versions again. #62994 |
There was a problem hiding this comment.
LGTM, confirmed it locally (unknown channel is because my git HEAD was detached to check out a PR commit):
Flutter 1.20.1-0.0.pre.2 • channel unknown • unknown source
Framework • revision 199983b4ff (16 minutes ago) • 2020-08-05 15:20:27 -0700
Engine • revision c8e3b94853
Tools • Dart 2.9.0
|
@pcsosinski CI has passed. |
pcsosinski
left a comment
pcsosinski
left a comment
There was a problem hiding this comment.
approved for 1.20, thanks @cyanglaz for getting this done and versioning fixed!
4 participants
This is a cherry-pick of 004f90f and 2459f5c
Fixes #60215
In order to land this while passing CI, I also had to cherry-pick c9cd825