Fix composited transform bounds calculations#6302
Merged
abarth merged 1 commit intoflutter:masterfrom Oct 13, 2016
Merged
Conversation
Contributor
Author
|
Still needs tests. |
Contributor
|
|
abarth
commented
Oct 13, 2016
Contributor
Author
There was a problem hiding this comment.
We do want the inverse transform.
Contributor
Author
There was a problem hiding this comment.
Turns out transformRect was doing the inverse transform already, which is why it worked. :)
We weren't computing the bounds for composited transforms correctly. We need to conjugate the transform by the offset in order to get the correct paint bounds for the composited layer. We now also use the same math in the non-composited case for consistency. Also, don't scale the z-coordinate in RenderFittedBox. Fixes flutter#6293
abarth
force-pushed
the
fix_transforms
branch
from
14de3c3 to
127aa7d
Compare
GaryQian
added a commit
that referenced
this pull request
Sep 22, 2018
Unbreak build. git log a8890fd..cc3009c --no-merges --oneline cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (#6309) bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (#6307) dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257) 2a1debf Update deprecated subtags from language subtag registry. (#6280) 540cd96 Add Xib splashscreen support (#6289) 05f21e6 (main) Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (#6297)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't computing the bounds for composited transforms correctly. We
need to conjugate the transform by the offset in order to get the
correct paint bounds for the composited layer. We now also use the same
math in the non-composited case for consistency.
Also, don't scale the z-coordinate in RenderFittedBox.
Fixes #6293