update dev/integration_tests/flutter_gallery/android/settings.gradle#63200
update dev/integration_tests/flutter_gallery/android/settings.gradle#63200CareF wants to merge 1 commit intoflutter:masterfrom CareF:gallery_settings_gradle_update
Conversation
|
@blasten last updated this gradle to its current content. This PR seems to be restoring the old gradle. Is this intended? |
|
It sounds like the resolved versions of |
|
@cyanglaz Should we make the change here or to somewhere in the plugins repo? |
|
@blasten @liyuqian These packages are pin-ed since #50365 due to the plugins' breaking change: Removing that version pin will break dev/integration_tests/flutter_gallery/test/smoke_test.dart. Updating files in the plugins won't help because we can't update the depended version in the framework repo.
|
|
This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it. |
|
Regarding #63200 (comment), shall we fix the flutter gallery smoke test so we no longer needs to pin |
|
Closing. It's sad that this didn't land, but at this point it's probably easier for us to do this from scratch if we decide it still need doings. |
Description
The current version of
dev/integration_tests/flutter_galleryis using a old settings.gradle that's not compatible with the plugins it's using, causing warning message:Related Issues
Fixes #63199
Tests
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.