[Windows] Fix unnecessary surface creation/destruction in startup path#63301
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Aug 31, 2020
Merged
[Windows] Fix unnecessary surface creation/destruction in startup path#63301fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
stuartmorgan-g
requested changes
Aug 10, 2020
packages/flutter_tools/templates/app/windows.tmpl/runner/win32_window.h
Outdated
Show resolved
Hide resolved
Author
|
CR feedback addres, I’m going to do one final check to confirm that we are indeed only creating a single surface on startup, now that the dependent change is in, then I think we’re good here once the tree goes green |
Author
|
OK, verified that there is only one surface creation now |
stuartmorgan-g
approved these changes
Aug 31, 2020
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I pushed a whitespace fix; LGTM with that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #63299 by passing the correct window size to the constructor of FlutterViewController rather than a temporary value.
This change is dependent on flutter/engine#20357 landing first.
Related Issues
#40068
Tests
No change in behavior introduced.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.