Tap above LongPressDraggable should work#6348
Merged
abarth merged 1 commit intoflutter:masterfrom Oct 17, 2016
Merged
Conversation
Contributor
Author
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes flutter#1186
Member
|
LGTM |
Hixie
reviewed
Oct 18, 2016
|
|
||
| /// Forces resolution of the arena, giving the win to the first member. | ||
| /// | ||
| /// Sweep is typically after all the other processing for a [PointerUpEvent] |
Contributor
There was a problem hiding this comment.
I think you a verb in the first sentence here.
Hixie
reviewed
Oct 18, 2016
| /// Prevents the arena from being swept. | ||
| /// | ||
| /// Typically, a winner is chosen in an arena after all the other | ||
| /// [PointerUpEvent] processing by [sweep]. If a recognizer wishes to delay |
Contributor
There was a problem hiding this comment.
put a comma after "processing" because otherwise it looks like the processing itself is done by "sweep", as opposed to the choosing of a winner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were nulling out the ArenaEntry in MultiDragPointerState
too early, which was prevent MultiDragPointerState from rejecting the
gesture in
disposeif we hadn't accepted by the time the pointer wentup. Now we properly reject the gesture, which causes the tap gesture to
win during
sweepin the arena.Also, add a bunch of docs and annotations based on information I learned
while studying this issue. Finally, rename a private member of tap
recognizer to a name that would have confused me less in my
investigation.
Fixes #1186