Skip to content

driver: forward device logs to local console#6360

Merged
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:driver-logs
Oct 17, 2016
Merged

driver: forward device logs to local console#6360
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:driver-logs

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Oct 17, 2016

@devoncarew
Copy link
Contributor

devoncarew commented Oct 17, 2016

lgtm

[lint] Cancel instances of dart.async.StreamSubscription. (packages/flutter_tools/lib/src/commands/drive.dart, line 87, col 30)

Looks like there's an issue w/ a lint - it's not able to determine that the subscription is cancelled.

danrubel
danrubel approved these changes Oct 17, 2016
View reviewed changes
Copy link
Contributor

@danrubel danrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once lint has been addressed.

packages/flutter_tools/lib/src/commands/drive.dart Outdated
Copy link
Contributor

@danrubel danrubel Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancel subscription if result.started (see code below) is false ?

Copy link
Contributor Author

@yjbanov yjbanov Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Done.

@yjbanov
Copy link
Contributor Author

yjbanov commented Oct 17, 2016

Looks like there's an issue w/ a lint

I'm not a fan of this lint. There's no way to make it reliable. I've seen many projects legitimately use subscription tracking utilities (often referred to as "disposers") to close them based on some life-cycle event, which the linter won't be able to figure out.

@yjbanov
Copy link
Contributor Author

yjbanov commented Oct 17, 2016

@devoncarew I added a "ignore: cancel_subscriptions" for now and will log a bug against the linter shortly.

@yjbanov yjbanov merged commit 88e065d into flutter:master Oct 17, 2016
@yjbanov yjbanov mentioned this pull request Oct 18, 2016
Closed
@a-siva a-siva mentioned this pull request Sep 27, 2018
Merged
a-siva added a commit that referenced this pull request Sep 27, 2018
@a-siva
Roll engine to version d80c1de
aef9804 
Contains the following changes:

d80c1de (HEAD -> master, upstream/master) Roll src/third_party/skia ab3144c3abb9..656cefe65d62 (11 commits) (#6362)
edf6249 Add pushOffset to SceneBuilder (#6349)
3a01f39 Change log level from ERROR to WARNING (#6361)
5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (#6360)
763627f Do not export libdart symbols (#6337)
3052dbd SystemNavigator.pop can pop w/o UINavigationController (#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (#6356)
c589b31 Expose push/popRoute on FlutterViewController (#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (#6354)
5b79938 Dont make any binaries specify an X11 dependency. (#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (#6278)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danrubel danrubel danrubel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

when a flutter drive test fails, you get an enormously long stack trace

3 participants

@yjbanov @devoncarew @danrubel