Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
a: accessibility
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM once it is clear why we need to disable that one lint and when we can re-enable it.
| - non-nullable | ||
| errors: | ||
| always_require_non_null_named_parameters: false # not needed with nnbd | ||
| prefer_initializing_formals: false # https://github.com/dart-lang/linter/issues/2192 |
There was a problem hiding this comment.
The issue linked is closed and from reading it it's not entirely clear to me what needs to happen to re-enable this?
There was a problem hiding this comment.
https://github.com/dart-lang/linter/issues/2192 is re-opened because the issue is not resolved yet. With that this comment is resolved.
|
Combined with the latest master, this PR is producing a dead_code analyzer warning. I am going to re-open it with an ignore for that at the right place to get it landed. |
|
Superseded by #64055. |
4 participants
Description
NNBD migration for semantics
Related Issues
Tests
I added the following tests:
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.