Incorrect path.join usage might be causing Windows test failures#64056
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Aug 19, 2020
Merged
Incorrect path.join usage might be causing Windows test failures#64056fluttergithubbot merged 3 commits intoflutter:masterfrom
fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
Member
|
I remember that there's some weirdness with asset paths on Windows /cc @jonahwilliams |
blasten
approved these changes
Aug 18, 2020
Contributor
|
I think the asset path weirdness is unrelated - it just seems like LUCI bots are stricter about |
Member
Author
|
what's the "asset path weirdness" you guys referring to? |
Member
Author
|
|
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing this incorrect path.join usage is causing LUCI failures on windows like https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8871652713241732960/+/steps/run_test.dart_for_hostonly_devicelab_tests_shard_and_subshard_3_last/0/stdout