Reland "fix wrap intrinsic height calculation (#63420)"#64276
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Aug 25, 2020
Merged
Reland "fix wrap intrinsic height calculation (#63420)"#64276fluttergithubbot merged 3 commits intoflutter:masterfrom
fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
This reverts commit 473744d.
flutter-dashboard
bot
added
the
framework
Member
|
I looked at this again in the context of #48679 and I believe this PR does not fix the intrinsics for Wrap. As far as I can tell, in the following code the intrinsic height is still calculated incorrectly to be 1 line when in fact it is 3 lines. Center(
child: Container(
width: 200,
height: 200,
color: Colors.green,
child: Align(
alignment: Alignment.topLeft,
child: IntrinsicHeight(
child: Container(
color: Colors.yellow,
child: Wrap(
children: [
Text('Start'),
Row(
children: [
Icon(Icons.edit, size: 16),
],
),
Text('End'),
],
),
),
),
),
)
);I believe the only fix for that is to implement the API outlined in #48679 (comment) because the problem is the same: We don't have an API to ask the Row-child what its intrinsics size is given the constraints we are gonna give it during layout. |
goderbauer
approved these changes
Aug 24, 2020
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
The plan is to land this to fix the specific issue in #63302 until we have implemented the more generic fix outlined in #48679 (comment).
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 473744d.
Description
Previous pr was reverted due to internal test failure. It is now ready to reland. Nothing has changed from previous pr
Related Issues
Fixes #63302
Tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.