Add finders for enableFlutterDriverExtension by Im-Kevin · Pull Request #64308 · flutter/flutter

Im-Kevin · 2020-08-21T08:01:38Z

Description

Add Custom Finder Support

Related Issues

#62299

Tests

I modified the following test:

extension_test.dart
- waitUntilNoTransientCallbacks
- waitForCondition
- getSemanticsId
- getOffset
- getText
- descendant finder
- descendant finder firstMatchOnly
- ancestor finder
- ancestor finder firstMatchOnly
- GetDiagnosticsTree
- waitUntilFrameSync
find_test.dart
- Ancestor finder deserialize
- Descendant finder deserialize

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

No, no existing tests failed, so this is not a breaking change.

googlebot · 2020-08-21T08:01:42Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Im-Kevin · 2020-08-21T12:21:12Z

@googlebot I signed it!

googlebot · 2020-08-21T12:21:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

goderbauer · 2020-08-21T21:06:49Z

/cc @dnfield

dnfield

I think I might be missing something here - a few nits, and some of the documentation needs more work.

Biggest question is about whether we can avoid just passing callbacks around so much, particularly ones that are just using Maps of stringly typed data.

packages/flutter_driver/lib/src/extension/extension.dart

packages/flutter_driver/test/src/real_tests/find_test.dart

packages/flutter_driver/lib/src/common/find.dart

Im-Kevin · 2020-08-29T08:03:18Z

@dnfield See how it is now

packages/flutter_driver/lib/src/extension/extension.dart

packages/flutter_driver/test/src/real_tests/find_test.dart

dnfield

Looks like this is getting closer!

Fix Code Style Error Co-authored-by: Dan Field <[email protected]>

Modified [enableFlutterDriverExtension] Code Note

marcin-jelenski · 2020-08-31T19:52:28Z

Fingers crossed @Im-Kevin.
Relates to the issue #62299.

packages/flutter_driver/lib/src/common/find.dart

packages/flutter_driver/lib/src/extension/extension.dart

Co-authored-by: Dan Field <[email protected]>

Im-Kevin · 2020-09-01T03:49:36Z

Im-Kevin · 2020-09-03T02:31:13Z

@dnfield

packages/flutter_driver/lib/src/extension/extension.dart

Im-Kevin · 2020-09-03T16:26:40Z

@dnfield See how it is now

packages/flutter_driver/lib/src/extension/extension.dart

dnfield · 2020-09-03T17:05:06Z

Tests are failing.

Co-authored-by: Dan Field <[email protected]>

Im-Kevin · 2020-09-04T02:24:06Z

@dnfield See how it is now

dnfield

LGTM

This reverts commit db4dda2.

…flutter#65273) This reverts commit db4dda2.

Add finders for enableFlutterDriverExtension

54e170a

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 21, 2020

googlebot added the cla: no label Aug 21, 2020

Im-Kevin added 3 commits August 21, 2020 16:37

Fix Code Style Error

70a0e1b

Move DeserializeFinderFactory And DeserializeFinder To find.dart

698728e

Remove Unused Import

f0dec6e

googlebot added cla: yes and removed cla: no labels Aug 21, 2020

dnfield suggested changes Aug 21, 2020

View reviewed changes

Modified the implementation of Finder extension

99d0ab2

enableFlutterDriverExtension add notes

f84057e

Im-Kevin requested a review from dnfield August 29, 2020 08:22

Im-Kevin added 2 commits August 29, 2020 16:44

Fix Code Style Error

b88db66

Fix Code Style Error

3e6d72b

dnfield reviewed Aug 29, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2020

View reviewed changes

packages/flutter_driver/test/src/real_tests/find_test.dart Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2020

View reviewed changes

Im-Kevin and others added 4 commits August 30, 2020 09:47

Update packages/flutter_driver/lib/src/extension/extension.dart

d19b906

Fix Code Style Error Co-authored-by: Dan Field <[email protected]>

Update packages/flutter_driver/test/src/real_tests/find_test.dart

dde689e

Fix Code Style Error Co-authored-by: Dan Field <[email protected]>

Update packages/flutter_driver/lib/src/extension/extension.dart

1521b30

Fix Code Style Error Co-authored-by: Dan Field <[email protected]>

Modified find_test.dart

34f6278

Modified [enableFlutterDriverExtension] Code Note

dnfield suggested changes Aug 31, 2020

View reviewed changes

Im-Kevin and others added 2 commits September 1, 2020 11:16

Update packages/flutter_driver/lib/src/common/find.dart

d829f8b

Co-authored-by: Dan Field <[email protected]>

Update packages/flutter_driver/lib/src/extension/extension.dart

bae44ef

Co-authored-by: Dan Field <[email protected]>

Im-Kevin requested a review from dnfield September 1, 2020 03:34

dnfield reviewed Sep 3, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

dnfield reviewed Sep 3, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

Modify enableFlutterDriverExtension Document

4e23766

dnfield reviewed Sep 3, 2020

View reviewed changes

packages/flutter_driver/lib/src/extension/extension.dart Outdated Show resolved Hide resolved

Im-Kevin and others added 2 commits September 4, 2020 01:05

Update packages/flutter_driver/lib/src/extension/extension.dart

2702c6b

Co-authored-by: Dan Field <[email protected]>

Merge branch 'master' of https://github.com/flutter/flutter

471dbda

Im-Kevin added 2 commits September 4, 2020 10:27

Modified [enableFlutterDriverExtension] Code Note

623dab0

Modified [enableFlutterDriverExtension] Code Note

a849e1b

dnfield approved these changes Sep 4, 2020

View reviewed changes

dnfield added the waiting for tree to go green label Sep 4, 2020

fluttergithubbot merged commit db4dda2 into flutter:master Sep 4, 2020

jonahwilliams pushed a commit that referenced this pull request Sep 5, 2020

Revert "Add finders for enableFlutterDriverExtension (#64308)"

bd0f1d4

This reverts commit db4dda2.

jonahwilliams mentioned this pull request Sep 5, 2020

Revert "Add finders for enableFlutterDriverExtension" #65273

Merged

jonahwilliams pushed a commit that referenced this pull request Sep 5, 2020

Revert "Add finders for enableFlutterDriverExtension (#64308)" (#65273)

14af5bb

This reverts commit db4dda2.

Im-Kevin mentioned this pull request Sep 5, 2020

Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit #65276

Merged

9 tasks

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Add finders for enableFlutterDriverExtension (flutter#64308)

b1a31de

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Revert "Add finders for enableFlutterDriverExtension (flutter#64308)" (…

0b01e38

…flutter#65273) This reverts commit db4dda2.

dnfield mentioned this pull request Sep 9, 2020

Make parameter optional #65444

Merged

marcin-jelenski mentioned this pull request Oct 6, 2020

Flutter Driver - Create widget finders from serialized finders extensions #67456

Merged

9 tasks

github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021

Conversation

Im-Kevin commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

googlebot commented Aug 21, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Im-Kevin commented Aug 21, 2020

Uh oh!

googlebot commented Aug 21, 2020

Uh oh!

goderbauer commented Aug 21, 2020

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Im-Kevin commented Aug 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

marcin-jelenski commented Aug 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Im-Kevin commented Sep 1, 2020

Uh oh!

Im-Kevin commented Sep 3, 2020

Uh oh!

Uh oh!

Uh oh!

Im-Kevin commented Sep 3, 2020

Uh oh!

Uh oh!

dnfield commented Sep 3, 2020

Uh oh!

Im-Kevin commented Sep 4, 2020

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Im-Kevin commented Aug 21, 2020 •

edited

Loading