Change iOS plugin simulator archs from allow list to deny list#64504
Merged
jmagman merged 1 commit intoflutter:masterfrom Aug 25, 2020
Merged
Change iOS plugin simulator archs from allow list to deny list#64504jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
jmagman
force-pushed
the
excluded-archs
branch
from
757725a to
2b93e97
Compare
jmagman
force-pushed
the
excluded-archs
branch
from
2b93e97 to
15fc556
Compare
Member
Author
|
Actually it might be better to declare this in the Flutter.podspec instead of the plugins. Let me try that... |
Member
Author
Nope it's needed on the plugin, too. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
Member
Author
|
#41828 didn't migrate existing plugins, this one doesn't either. I don't think we have any tooling for migrating this file for existing plugins... |
Member
|
LGTM. Good find |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This was referenced Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The intention of adding
VALID_ARCHSallow list was to excludei386simulators. However, at some point Flutter will need to run on the new ARM simulators. Change the allow list to a deny list and just excludei386.Related Issues
VALID_ARCHSadded in #41828Discovered with #63252.
Tests
This is already tested in plugin_lint_mac.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change