Slider paint incorrectly when the track shape is rectangular#64534
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Aug 28, 2020
Merged
Slider paint incorrectly when the track shape is rectangular#64534fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
xu-baolin
commented
Aug 26, 2020
| theme: ThemeData( | ||
| sliderTheme: const SliderThemeData( | ||
| trackShape: RectangularSliderTrackShape(), | ||
| )), |
Member
Author
There was a problem hiding this comment.
the second ) should at a new line
Member
Author
|
@HansMuller Hi, please review this change at your convenience, thanks very much! |
Merged
13 tasks
Member
Author
|
The |
Contributor
JoseAlba
approved these changes
Aug 28, 2020
Contributor
JoseAlba
left a comment
JoseAlba
left a comment
There was a problem hiding this comment.
██╗ ██████╗ ████████╗███╗ ███╗
██║ ██╔════╝ ╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
clocksmith
reviewed
Aug 28, 2020
| ]); | ||
| }); | ||
|
|
||
| testWidgets('Slider paint correctly when the track shape is rectangular', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
replace with: Slider track paints correctly when the shape is rectangular
HansMuller
approved these changes
Aug 28, 2020
| theme: ThemeData( | ||
| sliderTheme: const SliderThemeData( | ||
| trackShape: RectangularSliderTrackShape(), | ||
| ) |
| final Size thumbSize = sliderTheme.thumbShape.getPreferredSize(isEnabled, isDiscrete); | ||
|
|
||
| final Rect leftTrackSegment = Rect.fromLTRB(trackRect.left + trackRect.height / 2, trackRect.top, thumbCenter.dx - thumbSize.width / 2, trackRect.bottom); | ||
| final Rect leftTrackSegment = Rect.fromLTRB(trackRect.left, trackRect.top, thumbCenter.dx, trackRect.bottom); |
Contributor
There was a problem hiding this comment.
NICE. This is all much more obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This gap was added intended, see #31564, but this process is different from
RoundedRectSliderTrackShape, so I think we should remove it.Related Issues
Fixes #64696
Tests
I added the following tests:
See files.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.