[flutter_tools] add --config-only option to flutter build ios#64848
[flutter_tools] add --config-only option to flutter build ios#64848fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
tool
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
LGTM. You can also swap out the lines that say flutter build ios from https://flutter.dev/docs/deployment/cd as well since there's a fastlane step after.
|
|
||
| // Config is updated if command succeeded. | ||
| expect(generatedConfig, exists); | ||
| expect(generatedConfig.readAsStringSync(), contains('DART_OBFUSCATION=true')); |
There was a problem hiding this comment.
check a few more non-specified things like FLUTTER_FRAMEWORK_DIR is also pointing to reasonable places etc?
| '--config-only', | ||
| '--release', | ||
| '--obfuscate', | ||
| '--split-debug-info=info', |
There was a problem hiding this comment.
can you also add an "advanced" usage that synergizes with xcode more? Something like --flavor.
There was a problem hiding this comment.
--flavor does not change any of the generated config, it just controls which scheme we tell xcodebuild to use.
There was a problem hiding this comment.
true dat. How about --local-engine?
There was a problem hiding this comment.
we'll validate that it doesn't exist and fail :)
There was a problem hiding this comment.
as in you're going to assert users don't flutter build ios --config-only with --local-engine? Should we? If this is a flutter build ios --config-only command rather a flutter build ipa command, the intent is broader now no? We can't tell what the user wants to do and flutter build ios --config-only --local-engine can be a valid intent (e.g. this new path is now probably going to become the easiest way to flutter build ios --config-only --local-engine, then launch xcode and put a breakpoint on the engine code).
There was a problem hiding this comment.
no, the tool will fail to locate the local engine because it does not exist.
|
Still LGTM |
|
@xster you gotta hit the approve button so I get that little green checkmark :) |
|
That takes 2 round trips of changing tab then opening the review pop up. LGTM takes 0. |
|
After merging, we should sanity check with some interested users and the proceed to update website documentation (such as https://flutter.dev/docs/deployment/cd mentioned by @xster) once we have a min supported version from a dev release |
4 participants
Description
Allow updating the generated .xcconfig and pods without building the entire application. This is useful for avoiding duplicate work that would then be performed by Xcode archive anyway.
#13065
#64626