Disables test failing due to new semantics flag.#65194
Merged
chunhtai merged 1 commit intoflutter:masterfrom Sep 10, 2020
Merged
Disables test failing due to new semantics flag.#65194chunhtai merged 1 commit intoflutter:masterfrom
chunhtai merged 1 commit intoflutter:masterfrom
Conversation
12 tasks
chunhtai
approved these changes
Sep 8, 2020
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, you may need to rebase off master again to fix the failing test
d950801 to
83bd356
Compare
This change disables a failing test prevent PR flutter#20385 from merging.
83bd356 to
31d65a0
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables a failing test prevent engine PR flutter/engine#20385 from merging.
Description
PR flutter/engine#20385 failed to merge because of a failure in matchers_test.dart. This change disables the failing test to enable that merge.
Related Issues
flutter/engine#20385
Tests
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.