Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit#65276
Merged
fluttergithubbot merged 23 commits intoflutter:masterfrom Sep 8, 2020
Merged
Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit#65276fluttergithubbot merged 23 commits intoflutter:masterfrom
fluttergithubbot merged 23 commits intoflutter:masterfrom
Conversation
Fix Code Style Error Co-authored-by: Dan Field <[email protected]>
Fix Code Style Error Co-authored-by: Dan Field <[email protected]>
Fix Code Style Error Co-authored-by: Dan Field <[email protected]>
Modified [enableFlutterDriverExtension] Code Note
Co-authored-by: Dan Field <[email protected]>
Co-authored-by: Dan Field <[email protected]>
Co-authored-by: Dan Field <[email protected]>
flutter-dashboard
bot
added
a: tests
Contributor
Author
|
/ cc @dnfield |
dnfield
approved these changes
Sep 8, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM.
I'm a bit confused about how this passed CI last time though.
dnfield
reviewed
Sep 9, 2020
| class FlutterDriverExtension with DeserializeFinderFactory { | ||
| /// Creates an object to manage a Flutter Driver connection. | ||
| FlutterDriverExtension(this._requestDataHandler, this._silenceErrors) { | ||
| FlutterDriverExtension(this._requestDataHandler, this._silenceErrors, List<FinderExtension> finders) { |
Contributor
There was a problem hiding this comment.
unfortunately adding a new named parameter here breaks some internal customers. Can we reland this with either an optional named parameter, or just a new named constructor for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit
Related Issues
#65273
#64308
#62299
Tests
I modified the following test:
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.