Move the registration of the restoration channel to binding initialization#65579
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Sep 11, 2020
Merged
Move the registration of the restoration channel to binding initialization#65579fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
framework
…ation. Having side-effects in a getter is surprising and unintuitive. This reduces the side-effects caused by RestorationManager.rootBucket. Also, flutter/engine#21062 is planning on making the message queue draining asynchronous, so we need to make sure that we subscribe to messages before the build phase is scheduled, otherwise we will be delaying the first frame by one cycle.
Hixie
added
waiting for tree to go green
and removed
work in progress; do not review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having side-effects in a getter is surprising and unintuitive. This reduces the side-effects caused by RestorationManager.rootBucket.
Also, flutter/engine#21062 is planning on making the message queue draining asynchronous, so we need to make sure that we subscribe to messages before the build phase is scheduled, otherwise we will be delaying the first frame by one cycle.