Reland "perf test for measuring scroll smoothness"#65602
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Sep 11, 2020
Merged
Reland "perf test for measuring scroll smoothness"#65602fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: tests
liyuqian
changed the title
liyuqian
force-pushed
the
reland_resample_test
branch
from
6b0dca5 to
a264be3
Compare
This reverts commit 28de49e.
liyuqian
force-pushed
the
reland_resample_test
branch
from
a264be3 to
c7c27e0
Compare
Contributor
Author
|
CC @CareF as somehow I can't put you as the reviewer... |
Contributor
|
@liyuqian Thanks and LGTM. |
Contributor
Author
|
@CareF that must be an accident, and we apologize for that. Ray just added you back (sent you an invitation). Can you please check if it's received? |
This was referenced Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relands #61998
This reverts commit 28de49e.
No extra change seems to be needed to avoid the test failures in the old reland, probably thanks to #65124. I tested with iPhone 6s both locally and remotely on flutter-devicelab-mac-1.