[flutter_tools] fix failure to create ansi spinner if download needs to be retired#65797
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Sep 15, 2020
Merged
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
Looks like a flake: |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
|
Contributor
Author
|
Yeah, failure is unrelated. Will submit on green |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Sep 25, 2020
…to be retried (flutter#65797) Because the Status spinner was only created on setup, the second stop would asset/crash. Fixes flutter#65449
christopherfujino
added a commit
that referenced
this pull request
Sep 25, 2020
* Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (#66043) * [flutter_tools] fix failure to create ansi spinner if download needs to be retried (#65797) * Listen to Debug VM stream to get Stdout logs from VMService (#66310) * Update cherry picked engine Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because the Status spinner was only created on setup, the second stop would asset/crash.
Fixes #65449