Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor#66043
Conversation
flutter-dashboard
bot
added
framework
jonahwilliams
changed the title
|
Gold has detected about 3 untriaged digest(s) on patchset 4. |
flutter-dashboard
bot
added
the
c: contributor-productivity
jonahwilliams
changed the title
|
Gold has detected about 3 untriaged digest(s) on patchset 7. |
|
Gold has detected about 3 untriaged digest(s) on patchset 8. |
|
The change looks good. My current thinking is that we should only submit this if the original change (without this fix) did not and will not make it into any stable releases. Otherwise, this may actually be even more disruptive... |
|
This is probably worth cherry-picking? |
Nevermind, its an optional parameter now. So, if you already migrated, everything will continue to work. |
|
My problem still persist since this package https://pub.dev/packages/mp_chart is also depending on another package that uses the Velocity tracker class ->optimized_gesture_detector-0.0.5/lib/scale.dart:229:55: and requires a positional argument |
…er.withKind constructor (flutter#66043) We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional. Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter
…er.withKind constructor (flutter#66043) We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional. Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter
* Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (#66043) * [flutter_tools] fix failure to create ansi spinner if download needs to be retried (#65797) * Listen to Debug VM stream to get Stdout logs from VMService (#66310) * Update cherry picked engine Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
5 participants
Description
We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional.
Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter