Reland: TextSelectionTheme support (step 2 of 3)#66061
Merged
darrenaustin merged 1 commit intoflutter:masterfrom Sep 17, 2020
darrenaustin:text_selection_theme_opt_in_reland
Merged
Reland: TextSelectionTheme support (step 2 of 3)#66061darrenaustin merged 1 commit intoflutter:masterfrom darrenaustin:text_selection_theme_opt_in_reland
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:text_selection_theme_opt_in_reland
Conversation
flutter-dashboard
bot
added
f: material design
|
Gold has detected about 6 untriaged digest(s) on patchset 1. |
justinmc
approved these changes
Sep 17, 2020
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM
Is this part of the process for fixing the skia gold bot comments like the one on this PR?
Contributor
Author
No Kate already fixed gold. The problem was while it was broken, my original PR had broke the tree due to an image not being approved. Jonah reverted it to get the tree back to green. This is just a relanding now that gold has been fixed. |
Contributor
|
Got it, thanks! |
goderbauer
pushed a commit
to goderbauer/flutter
that referenced
this pull request
Sep 18, 2020
Turn the opt-in default for ThemeData.useTextSelectionTheme to true so that everything uses the new TextSelectionTheme by default.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR: #65044 was reverted due to a problem with the gold image system. Now that it has been resolved, this attempts to land it again.