Add Overflow back with deprecation#66305
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Sep 23, 2020
Merged
Conversation
flutter-dashboard
bot
added
the
framework
goderbauer
reviewed
Sep 22, 2020
| this.alignment = AlignmentDirectional.topStart, | ||
| this.textDirection, | ||
| this.fit = StackFit.loose, | ||
| this.overflow = Overflow.clip, |
Member
There was a problem hiding this comment.
I believe you also want to add the deprecation notice to this param here.
| /// hit testing. | ||
| /// | ||
| /// This overrides [clipBehavior] for now due to a staged roll out without | ||
| /// breaking Google. We will remove it and only use [clipBehavior] soon. |
Member
There was a problem hiding this comment.
Let's not mention google here.
| textDirection: TextDirection.ltr, | ||
| child: Center( | ||
| child: Stack( | ||
| overflow: Overflow.visible, |
Contributor
Author
There was a problem hiding this comment.
I was trying to revert the change in #61366. I can certainly remove this line but this line could test that overflow won't cause any compile error yet. Would you like me to remove this line?
| /// ([StackFit.expand]). | ||
| final StackFit fit; | ||
|
|
||
| @Deprecated( |
Member
There was a problem hiding this comment.
This should go after the doc comment.
| /// Whether overflowing children should be clipped, or their overflow be | ||
| /// visible. | ||
| /// | ||
| /// Deprecated. Use clipBehavior instead. |
Member
There was a problem hiding this comment.
Suggested change
| /// Deprecated. Use clipBehavior instead. | |
| /// Deprecated. Use [Stack.clipBehavior] instead. |
goderbauer
approved these changes
Sep 22, 2020
| passthrough, | ||
| } | ||
|
|
||
| @Deprecated( |
Member
There was a problem hiding this comment.
this deprecation should also go below the doc comment.
Comment on lines
+3337
to
+3338
| 'Use clipBehavior instead. See the migration guide in ' | ||
| 'flutter.dev/go/clip-behavior. This feature was deprecated after v1.22.' |
This was referenced Sep 24, 2020
This was referenced Sep 27, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the overflow option in the Stack is so popular, let's put it in deprecation for a while before completely removing it.
Fixes #66030