Listen to Debug VM stream to get Stdout logs from VMService#66310
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Sep 23, 2020
Merged
Listen to Debug VM stream to get Stdout logs from VMService#66310fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
Member
Author
|
If this gets cherry-picked to 1.20, I'll also add a version of https://github.com/flutter/flutter/pull/66293/files#diff-8af27919996ab2011c7860416c33b74bR51 to validate the logs are visible on |
e19d58e to
be61953
Compare
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Sep 25, 2020
christopherfujino
added a commit
that referenced
this pull request
Sep 25, 2020
* Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (#66043) * [flutter_tools] fix failure to create ansi spinner if download needs to be retried (#65797) * Listen to Debug VM stream to get Stdout logs from VMService (#66310) * Update cherry picked engine Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
iOS logging broke with #54132. The migration missed this logic:
If the debug stream isn't listened to, the VM service won't pass along
Stdout/Stderrevents.flutter attachnow shows logs.Related Issues
Fixes #65519.
Tests
Updated ios_device_logger_test.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change